Implement flux debug kustomization command
#5117
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Prodan <[email protected]>
Signed-off-by: Stefan Prodan <[email protected]>
Signed-off-by: Stefan Prodan <[email protected]>
stefanprodan
added
area/kustomization
Signed-off-by: Stefan Prodan <[email protected]>
matheuscscp
reviewed
Dec 17, 2024
matheuscscp
reviewed
Dec 17, 2024
| } | ||
| testEnv.CreateObjectFile(objectFile, tmpl, t) | ||
|
|
||
| cases := []struct { |
There was a problem hiding this comment.
Can we add 2 more tests: one for both flags set, and one for neither flags set?
darkowlzz
reviewed
Dec 17, 2024
Signed-off-by: Stefan Prodan <[email protected]>
darkowlzz
approved these changes
Dec 23, 2024
Comment on lines
+69
to
+71
| if (!debugKustomizationArgs.showStatus && !debugKustomizationArgs.showVars) || | ||
| (debugKustomizationArgs.showStatus && debugKustomizationArgs.showVars) { | ||
| return fmt.Errorf("either --show-status or --show-vars must be set") |
There was a problem hiding this comment.
As discussed before, we need to do this for debug helmrelease too. Maybe as part of this change or a separate PR.
matheuscscp
approved these changes
Dec 23, 2024
Signed-off-by: Stefan Prodan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the
flux debug kscommand as specified in #5109Followup: #5106
Closes: #5109